Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-47791: OCPBUGS-47792: update sdk-go and rest-api #400

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[release-4.17] OCPBUGS-47791: OCPBUGS-47792: update sdk-go and rest-api #400

merged 1 commit into from
Jan 6, 2025

Conversation

jzding
Copy link
Member

@jzding jzding commented Jan 6, 2025 •
edited
Loading

Update sdk-go and rest-api modules to fix the following issues:
OCPBUGS-47791
Unable to subscribe two or more consumers to the same PTP event
OCPBUGS-47792
Bad HTTP response (409) sent when the subscription request is not correct

@openshift-ci openshift-ci bot requested review from aneeshkp and vitus133 January 6, 2025 16:19
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@jzding jzding changed the title [release-4.17] update sdk-go and rest-api [release-4.17] OCPBUGS-47791: OCPBUGS-47792: update sdk-go and rest-api Jan 6, 2025
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-47791, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@jzding: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 44255db link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jzding
Copy link
Member Author

jzding commented Jan 6, 2025

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-47791, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-47478 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-47478 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding jzding merged commit 9284e7b into redhat-cne:release-4.17 Jan 6, 2025
2 of 7 checks passed
@openshift-ci-robot
Copy link

@jzding: Jira Issue OCPBUGS-47791: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47791 has been moved to the MODIFIED state.

In response to this:

Update sdk-go and rest-api modules to fix the following issues:
OCPBUGS-47791
Unable to subscribe two or more consumers to the same PTP event
OCPBUGS-47792
Bad HTTP response (409) sent when the subscription request is not correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.17.0-202501061704.p0.g9284e7b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshkp aneeshkp Awaiting requested review from aneeshkp

@vitus133 vitus133 Awaiting requested review from vitus133

Assignees
No one assigned
Labels
approved jira/severity-moderate jira/valid-bug jira/valid-reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzding @openshift-ci-robot @openshift-bot